[ 
https://issues.apache.org/jira/browse/RATIS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923141#comment-16923141
 ] 

Shashikant Banerjee commented on RATIS-650:
-------------------------------------------

Thanks [~sdeka] for working on this. The patch looks good .

Since, these specific metrics are only collected at leader  , would it make 
more sense to name it as LeaderMetrics rather than a RaftGroupMetrics?

Also, the below comment needs to be fixed syntactically.
{code:java}
// Normally, leader commit index is always ahead followers.
{code}

> Add metric to track lag between leader and follower in Log commit
> -----------------------------------------------------------------
>
>                 Key: RATIS-650
>                 URL: https://issues.apache.org/jira/browse/RATIS-650
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Shashikant Banerjee
>            Assignee: Supratim Deka
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: RATIS-650.000.patch
>
>
> Following metric indicates by how much each follower lags the leader with 
> respect to the log commit index.
> |raftServerCommitIndexDiff|difference between the next commitIndex between a 
> leader and each of its peer. This will give an idea at what of point of time 
> a follower lags/catches up with respect to leader|
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to