[
https://issues.apache.org/jira/browse/ROCKETMQ-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772503#comment-15772503
]
ASF GitHub Bot commented on ROCKETMQ-3:
---------------------------------------
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/9
ROCKETMQ-3 Clean up and perfect the unit test of rocketmq-broker
remove try catch, use assertNotNull etc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit 4a35f9575100ca04b379f7903f7134a406c3cd01
Author: zhendongliu.lzd <[email protected]>
Date: 2016-12-23T06:49:29Z
ROCKETMQ-3 Clean up and perfect the unit test of rocketmq-broker
commit b82d36f977dbfa6d966efc3a33d05e50a49c3b7c
Author: zhendongliu.lzd <[email protected]>
Date: 2016-12-23T07:14:15Z
Modify configs in BrokerTestHarness to avoid conflict
commit bc15c7345b58a4acc06c0a050602fed4faf01705
Author: zander <[email protected]>
Date: 2016-12-23T07:34:31Z
Remove unused imports
commit 3f979a8d8500a488a50c1f9830c7e72d27e1d4fa
Author: zander <[email protected]>
Date: 2016-12-23T10:21:23Z
ROCKETMQ-3 Clean up and perfect the unit test of rocketmq-broker, remove
try catch, use assertNotNull etc
----
> Clean up the unit test of rocketmq
> ----------------------------------
>
> Key: ROCKETMQ-3
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-3
> Project: Apache RocketMQ
> Issue Type: Task
> Reporter: Willem Jiang
>
> There are lots of System.out.println and the try...catch exception code in
> the test of rocketmq-store module. It's better to avoid the usage of
> System.out.println and just through out the exception to fail the test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
