[
https://issues.apache.org/jira/browse/ROCKETMQ-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15777431#comment-15777431
]
ASF GitHub Bot commented on ROCKETMQ-3:
---------------------------------------
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/11
[ROCKETMQ-3] Clean up unit tests, remove try...catch, using assertNull etc
Remove try...catch, using assertNull etc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq apache_pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit ec18e3530b7bc3067dcc7df1c04d3f5fff9244f0
Author: zhendongliu.lzd <[email protected]>
Date: 2016-12-26T02:31:45Z
[ROCKETMQ-3] Remove try...catch, using assertNull etc
----
> Clean up the unit test of rocketmq
> ----------------------------------
>
> Key: ROCKETMQ-3
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-3
> Project: Apache RocketMQ
> Issue Type: Task
> Reporter: Willem Jiang
>
> There are lots of System.out.println and the try...catch exception code in
> the test of rocketmq-store module. It's better to avoid the usage of
> System.out.println and just through out the exception to fail the test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
