[
https://issues.apache.org/jira/browse/ROCKETMQ-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15776490#comment-15776490
]
ASF GitHub Bot commented on ROCKETMQ-3:
---------------------------------------
Github user WillemJiang commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/9
@dongeforever I had some trouble to resolve the rebase merge conflict just
by pulling the changes from your branch( it looks like there some patch are
already merged into the master branch). Can you rebase the master branch and
use squash[1] create a single commit for it.
[1]https://makandracards.com/makandra/527-squash-several-git-commits-into-a-single-commit
> Clean up the unit test of rocketmq
> ----------------------------------
>
> Key: ROCKETMQ-3
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-3
> Project: Apache RocketMQ
> Issue Type: Task
> Reporter: Willem Jiang
>
> There are lots of System.out.println and the try...catch exception code in
> the test of rocketmq-store module. It's better to avoid the usage of
> System.out.println and just through out the exception to fail the test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
