[
https://issues.apache.org/jira/browse/ROCKETMQ-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784527#comment-15784527
]
ASF GitHub Bot commented on ROCKETMQ-18:
----------------------------------------
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94101719
--- Diff: store/src/main/java/org/apache/rocketmq/store/CommitLog.java ---
@@ -1150,15 +1150,15 @@ public AppendMessageResult doAppend(final long
fileFromOffset, final ByteBuffer
final byte[] propertiesData =
msgInner.getPropertiesString() == null ? null :
msgInner.getPropertiesString().getBytes(MessageDecoder.CHARSET_UTF8);
- final short propertiesLength = propertiesData == null ? 0 :
(short) propertiesData.length;
+ final int propertiesLength = propertiesData == null ? 0 :
propertiesData.length;
if (propertiesLength > Short.MAX_VALUE) {
log.warn("putMessage message properties length too long.
length={}", propertiesData.length);
return new
AppendMessageResult(AppendMessageStatus.PROPERTIES_SIZE_EXCEEDED);
}
final byte[] topicData =
msgInner.getTopic().getBytes(MessageDecoder.CHARSET_UTF8);
- final int topicLength = topicData == null ? 0 :
topicData.length;
--- End diff --
topicData may be null.
> Repackage com.alibaba to org.apache and change maven coordinate
> ---------------------------------------------------------------
>
> Key: ROCKETMQ-18
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-18
> Project: Apache RocketMQ
> Issue Type: Improvement
> Affects Versions: 4.0.0-incubating
> Reporter: vongosling
> Assignee: yukon
> Priority: Critical
> Labels: maven
> Fix For: 4.0.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
