[
https://issues.apache.org/jira/browse/ROCKETMQ-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784625#comment-15784625
]
ASF GitHub Bot commented on ROCKETMQ-18:
----------------------------------------
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103642
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/filtersrv/FilterServerUtil.java
---
@@ -26,9 +26,9 @@ public static void callShell(final String shellString,
final Logger log) {
String[] cmdArray = splitShellString(shellString);
process = Runtime.getRuntime().exec(cmdArray);
process.waitFor();
- log.info("callShell: <{}> OK", shellString);
+ log.info("CallShell: <{}> OK", shellString);
} catch (Throwable e) {
- log.error("callShell: readLine IOException, " + shellString,
e);
+ log.error("CallShell: readLine IOException, {}", shellString,
e);
--- End diff --
Wrong usage for log.error, please review it
> Repackage com.alibaba to org.apache and change maven coordinate
> ---------------------------------------------------------------
>
> Key: ROCKETMQ-18
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-18
> Project: Apache RocketMQ
> Issue Type: Improvement
> Affects Versions: 4.0.0-incubating
> Reporter: vongosling
> Assignee: yukon
> Priority: Critical
> Labels: maven
> Fix For: 4.0.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
