[
https://issues.apache.org/jira/browse/ROCKETMQ-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784623#comment-15784623
]
ASF GitHub Bot commented on ROCKETMQ-18:
----------------------------------------
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/21#discussion_r94103857
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/slave/SlaveSynchronize.java ---
@@ -106,12 +106,12 @@ private void syncDelayOffset() {
try {
MixAll.string2File(delayOffset, fileName);
} catch (IOException e) {
- log.error("persist file Exception, " + fileName,
e);
+ log.error("Persist file Exception, {}", fileName,
e);
}
}
- log.info("update slave delay offset from master, {}",
masterAddrBak);
+ log.info("Update slave delay offset from master, {}",
masterAddrBak);
} catch (Exception e) {
- log.error("syncDelayOffset Exception, " + masterAddrBak,
e);
+ log.error("SyncDelayOffset Exception, {}", masterAddrBak,
e);
--- End diff --
wrong
> Repackage com.alibaba to org.apache and change maven coordinate
> ---------------------------------------------------------------
>
> Key: ROCKETMQ-18
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-18
> Project: Apache RocketMQ
> Issue Type: Improvement
> Affects Versions: 4.0.0-incubating
> Reporter: vongosling
> Assignee: yukon
> Priority: Critical
> Labels: maven
> Fix For: 4.0.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
