[
https://issues.apache.org/jira/browse/ROCKETMQ-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804257#comment-15804257
]
ASF GitHub Bot commented on ROCKETMQ-34:
----------------------------------------
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/30
[ROCKETMQ-34] Potential NPE in NettyConnetManageHandler#connect
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-34
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-34
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit 2550ae56b98622344d2079c44a5f577b8d5a5f82
Author: shtykh_roman <[email protected]>
Date: 2017-01-06T10:32:09Z
[ROCKETMQ-34] Potential NPE in NettyConnetManageHandler#connect
JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-34
----
> Potential NPE in NettyConnetManageHandler#connect
> -------------------------------------------------
>
> Key: ROCKETMQ-34
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-34
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Minor
>
> According to {{NettyConnetManageHandler#connect}} logic, _remoteAddress_ can
> be _null_, therefore referring to it may be dangerous.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
