[
https://issues.apache.org/jira/browse/ROCKETMQ-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810550#comment-15810550
]
ASF GitHub Bot commented on ROCKETMQ-34:
----------------------------------------
Github user vintagewang commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/30
```
public void connect(ChannelHandlerContext ctx, SocketAddress
remoteAddress, SocketAddress localAddress, ChannelPromise promise)
throws Exception {
final String local = localAddress == null ? "UNKNOW" :
localAddress.toString();
final String remote = remoteAddress == null ? "UNKNOW" :
remoteAddress.toString();
log.info("NETTY CLIENT PIPELINE: CONNECT {} => {}", local,
remote);
super.connect(ctx, remoteAddress, localAddress, promise);
if (NettyRemotingClient.this.channelEventListener != null) {
NettyRemotingClient.this.putNettyEvent(new
NettyEvent(NettyEventType.CONNECT, remoteAddress.toString(), ctx.channel()));
}
}
```
Hi, @shroman is this ` super.connect` dangerous ?
> Potential NPE in NettyConnetManageHandler#connect
> -------------------------------------------------
>
> Key: ROCKETMQ-34
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-34
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Minor
>
> According to {{NettyConnetManageHandler#connect}} logic, _remoteAddress_ can
> be _null_, therefore referring to it may be dangerous.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
