[
https://issues.apache.org/jira/browse/ROCKETMQ-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15810605#comment-15810605
]
ASF GitHub Bot commented on ROCKETMQ-34:
----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/30
@vintagewang `super.connect` can throw NPE when remoteAddress is null,
but as far as I see in netty code, it is ok (notification is raised). And the
client handles this in `invoke*` methods by `throw new
RemotingConnectException(addr);` (for instance, NettyRemotingClient lines
518-519).
To summarize, it looks safe.
> Potential NPE in NettyConnetManageHandler#connect
> -------------------------------------------------
>
> Key: ROCKETMQ-34
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-34
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Minor
>
> According to {{NettyConnetManageHandler#connect}} logic, _remoteAddress_ can
> be _null_, therefore referring to it may be dangerous.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
