[jira] [Commented] (ROCKETMQ-104) Make MQAdmin commands throw exceptions

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870712#comment-15870712
 ] 

ASF GitHub Bot commented on ROCKETMQ-104:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/65
  
    
    [![Coverage 
Status](https://coveralls.io/builds/10192313/badge)](https://coveralls.io/builds/10192313)
    
    Coverage increased (+0.02%) to 31.538% when pulling 
**426b3f37686e6df05563d654493efc72e374ec40 on shroman:ROCKETMQ-104** into 
**573b22c37806a21543b90707bcce6022243a62da on apache:master**.



> Make MQAdmin commands throw exceptions
> --------------------------------------
>
>                 Key: ROCKETMQ-104
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-104
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> *Why to throw exceptions?*
> With the current implementation you don't know if the command fails unless 
> you look at console. This is one reason why errors in unit tests like in 
> ROCKETMQ-77 can go unnoticed.
> If stack tracing is still needed, we can add logging when throwing exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)