[ 
https://issues.apache.org/jira/browse/ROCKETMQ-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871431#comment-15871431
 ] 

ASF GitHub Bot commented on ROCKETMQ-104:
-----------------------------------------

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/65
  
    @zhouxinyu Thanks for checking it!
    Well, `@Ignore` is there just for finer granularity -- we remove it one by 
one when implementing each test. If you think we don't need it, I can remove ;)


> Make MQAdmin commands throw exceptions
> --------------------------------------
>
>                 Key: ROCKETMQ-104
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-104
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> *Why to throw exceptions?*
> With the current implementation you don't know if the command fails unless 
> you look at console. This is one reason why errors in unit tests like in 
> ROCKETMQ-77 can go unnoticed.
> If stack tracing is still needed, we can add logging when throwing exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to