[
https://issues.apache.org/jira/browse/ROCKETMQ-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871421#comment-15871421
]
ASF GitHub Bot commented on ROCKETMQ-104:
-----------------------------------------
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/65
Hi @shroman ,
LGTM, but why do we add so many `@Ignore` annotations in this PR? All the
he unit tests of tools module have been skipped in `tools/pom.xml`. We may
forget to remove these annotations after this issue[1] has been resolved.
[1]. https://issues.apache.org/jira/browse/ROCKETMQ-77
> Make MQAdmin commands throw exceptions
> --------------------------------------
>
> Key: ROCKETMQ-104
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-104
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> *Why to throw exceptions?*
> With the current implementation you don't know if the command fails unless
> you look at console. This is one reason why errors in unit tests like in
> ROCKETMQ-77 can go unnoticed.
> If stack tracing is still needed, we can add logging when throwing exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
