[jira] [Commented] (ROCKETMQ-135) Broker cannot be properly finalized on failure to load a storage plugin

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903370#comment-15903370
 ] 

ASF GitHub Bot commented on ROCKETMQ-135:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/73
  
    
    [![Coverage 
Status](https://coveralls.io/builds/10513484/badge)](https://coveralls.io/builds/10513484)
    
    Coverage increased (+0.04%) to 31.027% when pulling 
**dde713c5d9ee0269a10befb32057363248ba70c1 on shroman:ROCKETMQ-135** into 
**e3f4251c91a73f4e51732bcb1690554ac5fb3096 on apache:develop**.



> Broker cannot be properly finalized on failure to load a storage plugin
> -----------------------------------------------------------------------
>
>                 Key: ROCKETMQ-135
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-135
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker
>    Affects Versions: 4.0.0-incubating
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> When a storage plugin fails ( 
> {{org.apache.rocketmq.broker.plugin.MessageStoreFactory#build}} ), it 
> terminates the broker without proper finalization.
> This is because {{RuntimeException}} is thrown by the above-mentioned method 
> and it is never properly handled.
> I propose creating a {{BrokerException}}, throw it and properly handle.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)