[
https://issues.apache.org/jira/browse/ROCKETMQ-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904757#comment-15904757
]
ASF GitHub Bot commented on ROCKETMQ-135:
-----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/73
@Jaskey For a decorated class, you don't write "DecoratedClassA,
DecoratedClassB, DecoratedClassC" in your properties, do you? :) You just
specify your outer class, say "DecoratedClassC", and initialize. Inheritance
and composition are done for you.
The current code explicitly initializes all classes, and use only the
latest one.
> Broker cannot be properly finalized on failure to load a storage plugin
> -----------------------------------------------------------------------
>
> Key: ROCKETMQ-135
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-135
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Affects Versions: 4.0.0-incubating
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> When a storage plugin fails (
> {{org.apache.rocketmq.broker.plugin.MessageStoreFactory#build}} ), it
> terminates the broker without proper finalization.
> This is because {{RuntimeException}} is thrown by the above-mentioned method
> and it is never properly handled.
> I propose creating a {{BrokerException}}, throw it and properly handle.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
