[
https://issues.apache.org/jira/browse/ROCKETMQ-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906769#comment-15906769
]
ASF GitHub Bot commented on ROCKETMQ-135:
-----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/73
I would rather get suggestions about this modification, if any, instead of
hypothetical considerations. What is described here cannot be done with the
current RocketMQ code base -- it's not just config changes, you will need to
restart the broker cluster. In addition, from the code I cannot see that more
than one store at a time can be supported. Can anyone confirm?
> Broker cannot be properly finalized on failure to load a storage plugin
> -----------------------------------------------------------------------
>
> Key: ROCKETMQ-135
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-135
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Affects Versions: 4.0.0-incubating
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> When a storage plugin fails (
> {{org.apache.rocketmq.broker.plugin.MessageStoreFactory#build}} ), it
> terminates the broker without proper finalization.
> This is because {{RuntimeException}} is thrown by the above-mentioned method
> and it is never properly handled.
> I propose creating a {{BrokerException}}, throw it and properly handle.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
