[
https://issues.apache.org/jira/browse/ROCKETMQ-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066035#comment-16066035
]
ASF GitHub Bot commented on ROCKETMQ-223:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/119
@lizhanhui
In my option for your consern # 2, I even consider that we separate the
configuration logic from the default topic, since the clients may use different
default key.
In my option, the below flow may be much more clearer:
1. Default topic is always created , just like the other preserved topic.
2. auto-creation configuration has no impact on this default topic, while
it is a switch which enable the broker to support auto topic creation.
if (autoCreateTopicEnable) { //broker allow to auto create topic
if (topicKeyExist){ // exist the specified topic key
if (isInherite(topic)) { // topic has the right perm
log("topic key does not has the sufficient perm to auto
create topic ")
}
}
else {
log("The topic key does not exist")
}
} else {
log("broker does not allow to auto create topic")
}
> Rename DEFAULT_TOPIC
> --------------------
>
> Key: ROCKETMQ-223
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-223
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-commons
> Affects Versions: 4.0.0-incubating
> Reporter: Jaskey Lam
> Assignee: Jixiang Jin
> Priority: Minor
>
> DEFAULT_TOPIC is now set to `TBW102` which makes no sense to understand it's
> usage, actually this is an important topic which to support auto create topic
> when sending message.
> While because of the strange naming, user can hardly understand.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
