[
https://issues.apache.org/jira/browse/ROCKETMQ-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066323#comment-16066323
]
ASF GitHub Bot commented on ROCKETMQ-223:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/119
@lizhanhui .
I think we'd better rename the topic name also since it has impact many
users that they don't actually know what is this topic and hot to maintain it.
In the client code, the error of topic `defaultTopic` not exits will be
ignored so it has no impact for the current users, unless that they will not be
able to auto create topic if they only upgrade the broker but using the old
client and they do not specify another topic key.
If needed , we can refactor the code flow on topic auto creation on another
issue. For now, we just rename it to make it clear.
@shroman The reason I rename the variable is that the name `defaultTopic `
is confusing since it does not explain what it is used for and actually it is
not a defaultTopic since it may not exist if auto creation is disabled.
> Rename DEFAULT_TOPIC
> --------------------
>
> Key: ROCKETMQ-223
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-223
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-commons
> Affects Versions: 4.0.0-incubating
> Reporter: Jaskey Lam
> Assignee: Jixiang Jin
> Priority: Minor
>
> DEFAULT_TOPIC is now set to `TBW102` which makes no sense to understand it's
> usage, actually this is an important topic which to support auto create topic
> when sending message.
> While because of the strange naming, user can hardly understand.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
