[ 
https://issues.apache.org/jira/browse/ROCKETMQ-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066191#comment-16066191
 ] 

ASF GitHub Bot commented on ROCKETMQ-223:
-----------------------------------------

Github user lizhanhui commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/119
  
    Looks good to me. Actually some of the client code relies on presence of 
the topic which would log exceptions otherwise.
    
    IMO, we'd better rename the variable name only to maintain best backward 
compatibility. 


> Rename DEFAULT_TOPIC
> --------------------
>
>                 Key: ROCKETMQ-223
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-223
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-commons
>    Affects Versions: 4.0.0-incubating
>            Reporter: Jaskey Lam
>            Assignee: Jixiang Jin
>            Priority: Minor
>
> DEFAULT_TOPIC is now set to `TBW102` which makes no sense to understand it's 
> usage, actually this is an important topic which to support auto create topic 
> when sending message.
> While because of the strange naming, user can hardly understand.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to