[
https://issues.apache.org/jira/browse/ROCKETMQ-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106553#comment-16106553
]
ASF GitHub Bot commented on ROCKETMQ-253:
-----------------------------------------
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/140
[ROCKETMQ-253]Compress RegisterBrokerBody
Refer to the description part of [this
issue](https://issues.apache.org/jira/browse/ROCKETMQ-253) please.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq
compress_heartbeat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit ae7ac32cfc91c9ae7a9745abe8045456dbf19eb2
Author: Zhanhui Li <[email protected]>
Date: 2017-07-30T16:27:49Z
compress register broker body
commit 43173b482f6faaf8801ca92fdd3c45e173455879
Author: Zhanhui Li <[email protected]>
Date: 2017-07-30T16:38:18Z
Update name server to support both compressed and uncompressed registration
----
> Compress RegisterBrokerBody
> ---------------------------
>
> Key: ROCKETMQ-253
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-253
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-broker, rocketmq-commons, rocketmq-namesrv
> Reporter: Zhanhui Li
> Assignee: yukon
>
> RocketMQ Brokers periodically register itself against namesrv to maintain its
> liveness.
> In case a broker has many topics, a 10 thousand or more, two major
> problematic issues show up:
> 1) Current serialization of RegisterBrokerBody would create a large String
> object, which stresses GC a lot, especially when G1 is used.
> 2) Transmission this bulk of data takes up significant portion of bandwidth.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
