[jira] [Commented] (ROCKETMQ-253) Compress RegisterBrokerBody

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106556#comment-16106556
 ] 

ASF GitHub Bot commented on ROCKETMQ-253:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/140
  
    
    [![Coverage 
Status](https://coveralls.io/builds/12613613/badge)](https://coveralls.io/builds/12613613)
    
    Coverage decreased (-0.08%) to 39.122% when pulling 
**43173b482f6faaf8801ca92fdd3c45e173455879 on lizhanhui:compress_heartbeat** 
into **33a99a4148cd216c800276029003f0ea6db14045 on apache:develop**.



> Compress RegisterBrokerBody
> ---------------------------
>
>                 Key: ROCKETMQ-253
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-253
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-broker, rocketmq-commons, rocketmq-namesrv
>            Reporter: Zhanhui Li
>            Assignee: yukon
>
> RocketMQ Brokers periodically register itself against namesrv to maintain its 
> liveness.
> In case a broker has many topics, a 10 thousand or more, two major 
> problematic issues show up:
> 1) Current serialization of RegisterBrokerBody would create a large String 
> object, which stresses GC  a lot, especially when G1 is used.
> 2) Transmission this bulk of data takes up significant portion of bandwidth.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)