ASF GitHub Bot commented on ROCKETMQ-253:
Github user shroman commented on a diff in the pull request:
@@ -148,12 +148,13 @@ private RegisterBrokerResult registerBroker(
RemotingCommand request =
RegisterBrokerBody requestBody = new RegisterBrokerBody();
--- End diff --
How about setting a threshold for compression being triggered, because if
the data you compress is small, it overhead is higher than the benefits you get
from the compression?
> Compress RegisterBrokerBody
> Key: ROCKETMQ-253
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-253
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-broker, rocketmq-commons, rocketmq-namesrv
> Reporter: Zhanhui Li
> Assignee: yukon
> RocketMQ Brokers periodically register itself against namesrv to maintain its
> In case a broker has many topics, a 10 thousand or more, two major
> problematic issues show up:
> 1) Current serialization of RegisterBrokerBody would create a large String
> object, which stresses GC a lot, especially when G1 is used.
> 2) Transmission this bulk of data takes up significant portion of bandwidth.
This message was sent by Atlassian JIRA