[
https://issues.apache.org/jira/browse/ROCKETMQ-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121260#comment-16121260
]
ASF GitHub Bot commented on ROCKETMQ-257:
-----------------------------------------
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/144#discussion_r132393089
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
---
@@ -225,10 +225,13 @@ public void start() throws MQClientException {
switch (this.serviceState) {
case CREATE_JUST:
this.serviceState = ServiceState.START_FAILED;
- // If not specified,looking address from name server
- if (null == this.clientConfig.getNamesrvAddr()) {
+ // name server address and web server address should
be specified at least one
+ if (null == this.clientConfig.getNamesrvAddr() &&
MixAll.getWSAddr().equals(MixAll.WS_ADDR)) {
+ throw new MQClientException("name server address
and web server address should be specified at least one.", null);
--- End diff --
What if someone want to use default wsaddr?
> name server address and web server address should be specified at least one
> ---------------------------------------------------------------------------
>
> Key: ROCKETMQ-257
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-257
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
> Affects Versions: 4.1.0-incubating
> Environment: test and production
> Reporter: Eason Chen
> Assignee: Xiaorui Wang
> Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> if name server address and web server address both are not specified , client
> will not fetch the
> right name server and client will start fail, because the default
> wsAddr=http://jmenv.tbsite.net:8080/rocketmq/nsaddr is not reachable.
> {code:java}
> // name server address and web server address should be specified at least one
> if (null == this.clientConfig.getNamesrvAddr() &&
> MixAll.getWSAddr().equals(MixAll.WS_ADDR)) {
> throw new MQClientException("name server address and
> web server address should be specified at least one.", null);
> } else if (null == this.clientConfig.getNamesrvAddr()) {
> this.mQClientAPIImpl.fetchNameServerAddr();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
