[ 
https://issues.apache.org/jira/browse/ROCKETMQ-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125133#comment-16125133
 ] 

ASF GitHub Bot commented on ROCKETMQ-257:
-----------------------------------------

Github user Jaskey commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/144
  
    Actually, the existing design is that  :  we have a default name server 
service address, which will be specified in our doc(though it is indeed not 
demonstrated well for now), the default address is for the user's convenience 
that they just need to modify their hosts file and map the domain to the right 
service address.
    
    But of course, some user may consider the a strict limit will be better. It 
depends. @shroman @vongosling @zhouxinyu If so, we need to make wsAddr to 
default to null.
    
    Or , remains the design but demonstrated it better in our user guide.


> name server address and web server address should be specified at least one
> ---------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-257
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-257
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-client
>    Affects Versions: 4.1.0-incubating
>         Environment: test and production
>            Reporter: Eason Chen
>            Assignee: Xiaorui Wang
>            Priority: Minor
>             Fix For: 4.2.0-incubating
>
>
> if name server address and web server address both are not specified , client 
> will not fetch the   
>  right name server and client will start fail, because the default 
> wsAddr=http://jmenv.tbsite.net:8080/rocketmq/nsaddr is not reachable.
> {code:java}
> // name server address and web server address should be specified at least one
>                     if (null == this.clientConfig.getNamesrvAddr() && 
> MixAll.getWSAddr().equals(MixAll.WS_ADDR)) {
>                         throw new MQClientException("name server address and 
> web server address should be specified at least one.", null);
>                     } else if (null == this.clientConfig.getNamesrvAddr()) {
>                         this.mQClientAPIImpl.fetchNameServerAddr();
>                     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to