[jira] [Commented] (ROCKETMQ-257) name server address and web server address should be specified at least one

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125303#comment-16125303
 ] 

ASF GitHub Bot commented on ROCKETMQ-257:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/144
  
    
    [![Coverage 
Status](https://coveralls.io/builds/12819006/badge)](https://coveralls.io/builds/12819006)
    
    Coverage decreased (-0.1%) to 38.925% when pulling 
**2081bd43cdb15ecfef0a0f08a4e87368960a3ee3 on qqeasonchen:develop** into 
**332df78e2bb6caadfc6f4714450000ebb1f9d224 on apache:develop**.



> name server address and web server address should be specified at least one
> ---------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-257
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-257
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-client
>    Affects Versions: 4.1.0-incubating
>         Environment: test and production
>            Reporter: Eason Chen
>            Assignee: Xiaorui Wang
>            Priority: Minor
>             Fix For: 4.2.0-incubating
>
>
> if name server address and web server address both are not specified , client 
> will not fetch the   
>  right name server and client will start fail, because the default 
> wsAddr=http://jmenv.tbsite.net:8080/rocketmq/nsaddr is not reachable.
> {code:java}
> // name server address and web server address should be specified at least one
>                     if (null == this.clientConfig.getNamesrvAddr() && 
> MixAll.getWSAddr().equals(MixAll.WS_ADDR)) {
>                         throw new MQClientException("name server address and 
> web server address should be specified at least one.", null);
>                     } else if (null == this.clientConfig.getNamesrvAddr()) {
>                         this.mQClientAPIImpl.fetchNameServerAddr();
>                     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)