[
https://issues.apache.org/jira/browse/ROCKETMQ-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143307#comment-16143307
]
ASF GitHub Bot commented on ROCKETMQ-264:
-----------------------------------------
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135431420
--- Diff:
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
@@ -97,54 +110,46 @@ public MessageExtBrokerInner buildMessage() {
@Test
public void testGroupCommit() throws Exception {
- long totalMsgs = 100;
+ long totalMsgs = 10;
QUEUE_TOTAL = 1;
MessageBody = StoreMessage.getBytes();
- MessageStoreConfig messageStoreConfig = new MessageStoreConfig();
- messageStoreConfig.setMapedFileSizeCommitLog(1024 * 8);
- messageStoreConfig.setFlushDiskType(FlushDiskType.SYNC_FLUSH);
- MessageStore master = new DefaultMessageStore(messageStoreConfig,
null, new MyMessageArrivingListener(), new BrokerConfig());
- boolean load = master.load();
- assertTrue(load);
+ for (long i = 0; i < totalMsgs; i++) {
+ messageStore.putMessage(buildMessage());
+ }
- master.start();
- verifyThatMasterIsFunctional(totalMsgs, master);
+ for (long i = 0; i < totalMsgs; i++) {
+ GetMessageResult result = messageStore.getMessage("GROUP_A",
"TOPIC_A", 0, i, 1024 * 1024, null);
+ assertThat(result).isNotNull();
+ result.release();
+ }
+ verifyThatMasterIsFunctional(totalMsgs, messageStore);
}
private void verifyThatMasterIsFunctional(long totalMsgs, MessageStore
master) {
- try {
- for (long i = 0; i < totalMsgs; i++) {
- master.putMessage(buildMessage());
- }
-
- for (long i = 0; i < totalMsgs; i++) {
- GetMessageResult result = master.getMessage("GROUP_A",
"TOPIC_A", 0, i, 1024 * 1024, null);
- assertThat(result).isNotNull();
- result.release();
-
- }
- } finally {
- master.shutdown();
- master.destroy();
+ for (long i = 0; i < totalMsgs; i++) {
+ master.putMessage(buildMessage());
+ }
+
+ for (long i = 0; i < totalMsgs; i++) {
+ GetMessageResult result = master.getMessage("GROUP_A",
"TOPIC_A", 0, i, 1024 * 1024, null);
+ assertThat(result).isNotNull();
+ result.release();
+
}
}
@Test
public void testPullSize() throws Exception {
- MessageStore messageStore = buildMessageStore();
- boolean load = messageStore.load();
- assertTrue(load);
- messageStore.start();
String topic = "pullSizeTopic";
for (int i = 0; i < 32; i++) {
MessageExtBrokerInner messageExtBrokerInner = buildMessage();
messageExtBrokerInner.setTopic(topic);
messageExtBrokerInner.setQueueId(0);
- PutMessageResult putMessageResult =
messageStore.putMessage(messageExtBrokerInner);
+ messageStore.putMessage(messageExtBrokerInner);
}
//wait for consume queue build
- Thread.sleep(100);
+ Thread.sleep(10);
--- End diff --
In test scenario, 10ms is enough.
> Unit test cost too long and there is exception in unit test
> -----------------------------------------------------------
>
> Key: ROCKETMQ-264
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-264
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: lindzh
> Assignee: vongosling
>
> When run mvn test , it cost too much time and some times there is exception
> in unit test and the test result is pass
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
