[jira] [Commented] (ROCKETMQ-264) Unit test cost too long and there is exception in unit test

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143328#comment-16143328
 ] 

ASF GitHub Bot commented on ROCKETMQ-264:
-----------------------------------------

Github user lindzh commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135436434
  
    --- Diff: 
store/src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest.java ---
    @@ -43,15 +43,24 @@
         private SocketAddress BornHost;
         private SocketAddress StoreHost;
         private byte[] MessageBody;
    +    private MessageStore messageStore;
     
         @Before
         public void init() throws Exception {
             StoreHost = new InetSocketAddress(InetAddress.getLocalHost(), 
8123);
             BornHost = new 
InetSocketAddress(InetAddress.getByName("127.0.0.1"), 0);
    +
    +        messageStore = buildMessageStore();
    +        boolean load = messageStore.load();
    +        assertTrue(load);
    +        messageStore.start();
         }
     
         @After
         public void destory() {
    +        messageStore.shutdown();
    +        messageStore.destroy();
    --- End diff --
    
    Delete created files has been did before at this file after destroy.


> Unit test cost too long and there is exception in unit test
> -----------------------------------------------------------
>
>                 Key: ROCKETMQ-264
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-264
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: lindzh
>            Assignee: vongosling
>
> When run mvn test , it cost too much time and some times there is exception 
> in unit test and the test result is pass



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)