[
https://issues.apache.org/jira/browse/ROCKETMQ-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143331#comment-16143331
]
ASF GitHub Bot commented on ROCKETMQ-264:
-----------------------------------------
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/145#discussion_r135436908
--- Diff:
broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
---
@@ -76,6 +86,24 @@
}
}
+ @Before
+ public void init() {
+ filterManager = ConsumerFilterManagerTest.gen(topicCount,
msgPerTopic);
+ try {
+ master = gen(filterManager);
+ } catch (Exception e) {
+ e.printStackTrace();
--- End diff --
This is a DefaultMessageStore start progress that used in annotation
Before.And can't add expect Exception in before,I think there is no need to add
exception expect in before and all we want is while the messageStore is started
or not.
> Unit test cost too long and there is exception in unit test
> -----------------------------------------------------------
>
> Key: ROCKETMQ-264
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-264
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: lindzh
> Assignee: vongosling
>
> When run mvn test , it cost too much time and some times there is exception
> in unit test and the test result is pass
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
