joshtynjala commented on pull request #1041:
URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814336955
FYI — The Mustella tests have been failing since this pull request was
merged. We haven't had a successful CI build since January.
The error we get is included below, and it seems to be a variation of the
original error that this pull request was trying to fix. If I revert this
commit locally, the Mustella tests pass successfully, so this change seems to
have side effects that were not fully accounted for.
```
ArgumentError: Error #2024: An object cannot be added as a child of itself.
at flash.display::DisplayObjectContainer/addChild()
at
org.apache.royale.core::UIBase/$sprite_addChild()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1584]
at
org.apache.royale.core::UIBase/addElement()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1175]
at
org.apache.royale.core::ContainerBase/addElement()[/org/apache/royale/0.9.8/org/apache/royale/core/ContainerBase.as:110]
at
org.apache.royale.html.beads::ContainerView/addViewport()[/org/apache/royale/0.9.8/org/apache/royale/html/beads/ContainerView.as:169]
at org.apache.royale.html.beads::ContainerView/set
strand()[/org/apache/royale/0.9.8/org/apache/royale/html/beads/ContainerView.as:155]
at
org.apache.royale.core::HTMLElementWrapper/addBead()[/org/apache/royale/0.9.8/org/apache/royale/core/HTMLElementWrapper.as:66]
at
org.apache.royale.core::UIBase/addBead()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1148]
at
global/org.apache.royale.utils::loadBeadFromValuesManager()[/org/apache/royale/0.9.8/org/apache/royale/utils/loadBeadFromValuesManager.as:55]
at
org.apache.royale.core::UIBase/loadBeads()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1419]
at
org.apache.royale.core::UIBase/addedToParent()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1402]
at
org.apache.royale.core::GroupBase/addedToParent()[/org/apache/royale/0.9.8/org/apache/royale/core/GroupBase.as:109]
at
org.apache.royale.html::Container/addedToParent()[/org/apache/royale/0.9.8/org/apache/royale/html/Container.as:104]
at
org.apache.royale.core::UIBase/addElementAt()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1209]
at
org.apache.royale.core::GroupBase/addElementAt()[/org/apache/royale/0.9.8/org/apache/royale/core/GroupBase.as:302]
at
org.apache.royale.core::SimpleStatesImpl/apply()[/org/apache/royale/0.9.8/org/apache/royale/core/SimpleStatesImpl.as:211]
at
org.apache.royale.core::SimpleStatesImpl/stateChangeHandler()[/org/apache/royale/0.9.8/org/apache/royale/core/SimpleStatesImpl.as:110]
at flash.events::EventDispatcher/dispatchEventFunction()
at flash.events::EventDispatcher/dispatchEvent()
at
org.apache.royale.core::UIBase/dispatchEvent()[/org/apache/royale/0.9.8/org/apache/royale/core/UIBase.as:1577]
at
global/org.apache.royale.utils::sendEvent()[/org/apache/royale/0.9.8/org/apache/royale/utils/sendEvent.as:40]
at org.apache.royale.core::GroupBase/set
currentState()[/org/apache/royale/0.9.8/org/apache/royale/core/GroupBase.as:261]
at
SetProperty/doStep()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/SetProperty.as:90]
at
TestStep/execute()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/TestStep.as:75]
at
SetProperty/execute()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/SetProperty.as:52]
at
TestCase/runSteps()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/TestCase.as:443]
at
TestCase/runBody()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/TestCase.as:318]
at
TestCase/runSetup()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/TestCase.as:296]
at
TestCase/runTest()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/TestCase.as:264]
at
UnitTester/runTests()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/UnitTester.as:2113]
at
UnitTester/startTests()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/UnitTester.as:2046]
at
ScriptRunner/runScripts()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/ScriptRunner.as:41]
at
UnitTester$/enterFrameHandler()[/Users/joshtynjala/Development/apache/royale-asjs/mustella/src/main/royale/UnitTester.as:1253]
```
It appears to fail on this test file, in particular:
https://github.com/apache/royale-asjs/blob/develop/mustella/tests/basicTests/halo/views/ButtonTests.mxml
To test Mustella tests locally, you can run this command (the framework must
already be built):
```sh
ant basictests-mustella
```
To build the full framework and run Mustella tests together in one command,
if that's needed:
```sh
ant main basictests-mustella
```
I'm still trying to figure out what's going on with this bug, but I am not
very familiar with the framework side of Royale. I tend to work on the compiler
only. Someone more familiar with the framework may be able to figure it out
faster than I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
