joshtynjala commented on pull request #1041:
URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814471244


   > I'm not sure your change to addViewport() is the right way to go
   
   Yeah, I've determined that my change to addViewport() is what was breaking 
the `MouseEventConverter` stuff. My `addViewport()` change seems to have simply 
not added the child anywhere, so there was no way for the `MouseEvent` 
`capture` listeners in the root `Application` to do the automatic conversion.
   
   I always assumed anything I tried to do to fix the broken Mustella tests 
would probably be a temporary workaround that someone else could make a better 
fix for later (since I don't know the framework side of things well), so if you 
have something better, that's great.
   
   If you can provide the better solution later this week, then I'll leave you 
to it. If you need more time, it might be a good idea to revert this commit 
temporarily so that we can get CI builds working again. Let me know what you 
think about that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to