estanglerbm commented on pull request #1041: URL: https://github.com/apache/royale-asjs/pull/1041#issuecomment-814462965
Things are more complicated, regarding changing this kind of thing, than I can quickly write here. Also, I didn't have full access to running ant tests at the time, and I should have run this test. I can look at this later this week, if that's OK. I also have some unchecked-in items that may help, but I'm not sure. Briefly, though, the relationship between Flash and Royale events are a little more complicated than automatic conversion. And I'm not sure your change to addViewport() is the right way to go; the point of this PR was to start the process toward fixing the way elements were being added in Spark and MX in different scenarios (which I finished but haven't fully checked in yet, I believe). [Got a little side-tracked on something else. Sorry about being vague; I've been away since January, and I need to catch up.] Before the PR, it was really difficult to debug some things on the Spark / MX side, due to the big differences between SWF and JS in this class. But certainly, if something breaks non-Spark / non-MX, then it needs to be fixed, since that's higher priority -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
