jiayuasu commented on code in PR #1162:
URL: https://github.com/apache/sedona/pull/1162#discussion_r1436801627
##########
spark/spark-3.5/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/GeoParquetWriteSupport.scala:
##########
@@ -172,9 +186,10 @@ class GeoParquetWriteSupport extends
WriteSupport[InternalRow] with Logging {
val bbox = if (geometryTypes.nonEmpty) {
Seq(columnInfo.bbox.minX, columnInfo.bbox.minY,
columnInfo.bbox.maxX, columnInfo.bbox.maxY)
} else Seq(0.0, 0.0, 0.0, 0.0)
- columnName -> GeometryFieldMetaData("WKB", geometryTypes, bbox)
+ val crs =
geoParquetColumnCrsMap.get(columnName).orElse(defaultGeoParquetCrs)
Review Comment:
According to the geoparquet spec, if a CRS is not given, then the crs field
of the geoparquet should be omitted assuming this is CRS84. If a CRS is set
null, then the crs field of the geoparquet should be set null.
The question is how a user can specify the null here. I think the user need
to manually specify `geoparquet.crs` -> `null` via the options. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
