Kontinuation commented on code in PR #1162:
URL: https://github.com/apache/sedona/pull/1162#discussion_r1437324962
##########
spark/spark-3.5/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/GeoParquetWriteSupport.scala:
##########
@@ -172,9 +186,10 @@ class GeoParquetWriteSupport extends
WriteSupport[InternalRow] with Logging {
val bbox = if (geometryTypes.nonEmpty) {
Seq(columnInfo.bbox.minX, columnInfo.bbox.minY,
columnInfo.bbox.maxX, columnInfo.bbox.maxY)
} else Seq(0.0, 0.0, 0.0, 0.0)
- columnName -> GeometryFieldMetaData("WKB", geometryTypes, bbox)
+ val crs =
geoParquetColumnCrsMap.get(columnName).orElse(defaultGeoParquetCrs)
Review Comment:
GeoPandas 0.13.2 works with shapely >=1.7.1, so it does not require shapely
2.0. I've confirmed that it works fine with shapely 1.8.5 and could pass all
the tests after applying https://github.com/apache/sedona/pull/1163.
If we decide to upgrade GeoPandas and drop Python 3.7 in the next release,
we can keep setting `crs` as `null` by default for now, and allow user to
explicitly omit `crs` by setting `geoparquet.crs` to `""`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
