jiayuasu commented on code in PR #1162:
URL: https://github.com/apache/sedona/pull/1162#discussion_r1437200549
##########
spark/spark-3.5/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/GeoParquetWriteSupport.scala:
##########
@@ -172,9 +186,10 @@ class GeoParquetWriteSupport extends
WriteSupport[InternalRow] with Logging {
val bbox = if (geometryTypes.nonEmpty) {
Seq(columnInfo.bbox.minX, columnInfo.bbox.minY,
columnInfo.bbox.maxX, columnInfo.bbox.maxY)
} else Seq(0.0, 0.0, 0.0, 0.0)
- columnName -> GeometryFieldMetaData("WKB", geometryTypes, bbox)
+ val crs =
geoParquetColumnCrsMap.get(columnName).orElse(defaultGeoParquetCrs)
Review Comment:
This sounds good to me but GeoPandas > 0.11 requires shapely 2.0, and our
other Python functions will not work in this case.
So maybe we still set the crs `null` by default and change the default
behavior in the next major release 1.6.0, in which we will add Shapely 2.0
support?
Other parts look good to me:
```
The value for geoparquet.crs or geoparquet.crs.<column_name> option user
specified can be one of the following values:
"" (empty string): omit the crs metadata
"null": explicitly setting crs as null
"{...PROJJSON...}": explicitly setting crs to specified PROJJSON object
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
