Kontinuation commented on code in PR #150:
URL: https://github.com/apache/sedona-db/pull/150#discussion_r2378086097
##########
r/sedonadb/src/Makevars.in:
##########
@@ -40,7 +40,6 @@ $(STATLIB):
# therefore is only used if cargo is absent from the user's PATH.
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
export CC="$(CC)" && \
- export CFLAGS="$(CFLAGS)" && \
Review Comment:
I am removing this because it triggers a problem after upgrading
`aws-lc-sys` from 0.31.0 to 0.32.0. aws-lc requires that the jitterentropy
module be compiled without compiler optimization enabled (see
https://github.com/aws/aws-lc/blob/2449607d740a5a8168c8a1366a57a3d91c80b16c/third_party/jitterentropy/jitterentropy-library/src/jitterentropy-base.c#L46-L48).
Setting CFLAGS will result in the following error:
```
cargo:warning=/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.32.0/aws-lc/third_party/jitterentropy/jitterentropy-library/src/jitterentropy-base.c:47:3:
error: "The CPU Jitter random number generator must not be compiled with
optimizations. See documentation. Use the compiler switch -O0 for compiling
jitterentropy.c."
cargo:warning= 47 | #error "The CPU Jitter random number generator must
not be compiled with optimizations. See documentation. Use the compiler switch
-O0 for compiling jitterentropy.c."
cargo:warning= | ^
cargo:warning=1 error generated.
exit status: 1
```
The CMakeLists.txt of jitterentropy module explicitly disabled compiler
optimization
(https://github.com/aws/aws-lc/blob/2449607d740a5a8168c8a1366a57a3d91c80b16c/third_party/jitterentropy/CMakeLists.txt),
we don't want to mess it up by setting up CFLAGS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
