yutannihilation commented on code in PR #150:
URL: https://github.com/apache/sedona-db/pull/150#discussion_r2378255196
##########
r/sedonadb/src/Makevars.in:
##########
@@ -40,7 +40,6 @@ $(STATLIB):
# therefore is only used if cargo is absent from the user's PATH.
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
export CC="$(CC)" && \
- export CFLAGS="$(CFLAGS)" && \
Review Comment:
(Just a comment and I'm no expert here...)
Sorry for the trouble. I checked why I put `CFLAGS` here, and I think
removing `CFLAGS` is fine because `CFLAGS` is not necessary in most cases.
One exception is when building the R package for
[webR](https://docs.r-wasm.org/webr/latest/). So, at first, I added `CFLAGS`
only on the webR case. But, later in
https://github.com/yutannihilation/savvy/commit/b0fa0bb9c53270eec7ffa32bc105ecad89d6709a,
I tweaked the `Makevars` to always add `CFLAGS` in the assumption it is
harmless. I think the intension was to simplify the code, so there's no strong
reason to use `CFLAGS` (at least until the day when sedona-db targets web
browsers.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
