Kontinuation commented on code in PR #150:
URL: https://github.com/apache/sedona-db/pull/150#discussion_r2379618179
##########
r/sedonadb/src/Makevars.in:
##########
@@ -40,7 +40,6 @@ $(STATLIB):
# therefore is only used if cargo is absent from the user's PATH.
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
export CC="$(CC)" && \
- export CFLAGS="$(CFLAGS)" && \
Review Comment:
It is strange that
[`prepare_jitter_entropy_builder`](https://github.com/aws/aws-lc-rs/blob/ee368e0689b2a0aee973e2d5be50a2c8d8b64374/aws-lc-sys/builder/cc_builder.rs#L379-L397)
does not override CFLAGS when using the cc builder. Setting
`AWS_LC_SYS_CFLAGS=$(CFLAGS) -O0` may turn off optimization for all modules,
which is not what we want. Let's just go ahead using the CMake builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
