yunchipang commented on code in PR #2386:
URL: https://github.com/apache/sedona/pull/2386#discussion_r2423083406
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -585,7 +585,10 @@ def test_is_ring(self):
self.check_pd_series_equal(sgpd_result, gpd_result)
def test_is_ccw(self):
- pass
+ for geom in self.linestrings:
Review Comment:
@petern48 thanks for the heads up! sorry I was not aware of the situation.
I've raised #2387 to fix this for `is_closed` and I'm going to close this PR.
please lmk which ones in #2230 could be easier to implement if you have some in
mind. i'd love to help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
