petern48 commented on code in PR #2386:
URL: https://github.com/apache/sedona/pull/2386#discussion_r2423107368
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -585,7 +585,10 @@ def test_is_ring(self):
self.check_pd_series_equal(sgpd_result, gpd_result)
def test_is_ccw(self):
- pass
+ for geom in self.linestrings:
Review Comment:
Sure! I think in general, most should be pretty easy. As I just mentioned in
the issue, I updated the list with corresponding Sedona functions. I'd
recommend any of those, since I expect them to be straightforward. It's
possible that some are not, but the only way to be sure is to try it out. I
think most cases will be as simple as your `is_closed` PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
