petern48 commented on code in PR #2386:
URL: https://github.com/apache/sedona/pull/2386#discussion_r2422367836
##########
python/tests/geopandas/test_match_geopandas_series.py:
##########
@@ -585,7 +585,10 @@ def test_is_ring(self):
self.check_pd_series_equal(sgpd_result, gpd_result)
def test_is_ccw(self):
- pass
+ for geom in self.linestrings:
Review Comment:
I didn't catch it originally (totally my bad), but the same goes for your
[other PR](https://github.com/apache/sedona/pull/2378) for `is_closed` since
the docstring mentions the result should be False. Could you try updating it to
`self.geoms` there too? I think it would pass, but it fails, we can instead
leave alone and file a new (bug) issue to fix the implementation in a separate
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
