petern48 commented on code in PR #241:
URL: https://github.com/apache/sedona-db/pull/241#discussion_r2462374867
##########
c/sedona-geos/src/st_buffer.rs:
##########
@@ -32,6 +32,19 @@ use sedona_schema::{
use crate::executor::GeosExecutor;
/// ST_Buffer() implementation using the geos crate
+///
+/// Supports three signatures:
+/// - ST_Buffer(geometry: Geometry, distance: Double)
+/// - ST_Buffer(geometry: Geometry, distance: Double, useSpheroid: Boolean)
+/// - ST_Buffer(geometry: Geometry, distance: Double, useSpheroid: Boolean,
bufferStyleParameters: String)
Review Comment:
I see you're following Sedona's buffer signatures.
I think we want to follow PostGIS's signatures, which don't include
useSpheroid. @paleolimbot Confirm?
https://postgis.net/docs/ST_Buffer.html
We already have this one:
`ST_Buffer(geometry g1, float radius_of_buffer);`
This is the one I had in mind in the issue
`ST_Buffer(geometry g1, float radius_of_buffer, text buffer_style_parameters
= '');`
PostGIS also supports the below signature. To my understanding, it's just
the quad_segs argument in buffer style params, so it's not new functionality.
You're welcome to implement this too, though I mainly had the previous one in
mind.
`ST_Buffer(geometry g1, float radius_of_buffer, integer
num_seg_quarter_circle);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
