paleolimbot commented on code in PR #241:
URL: https://github.com/apache/sedona-db/pull/241#discussion_r2462389751
##########
c/sedona-geos/src/st_buffer.rs:
##########
@@ -32,6 +32,19 @@ use sedona_schema::{
use crate::executor::GeosExecutor;
/// ST_Buffer() implementation using the geos crate
+///
+/// Supports three signatures:
+/// - ST_Buffer(geometry: Geometry, distance: Double)
+/// - ST_Buffer(geometry: Geometry, distance: Double, useSpheroid: Boolean)
+/// - ST_Buffer(geometry: Geometry, distance: Double, useSpheroid: Boolean,
bufferStyleParameters: String)
Review Comment:
Yes, I think we want PostGIS signatures for now. PostGIS and Sedona Spark
implement the spheroidal buffer by reprojecting, doing a buffer, then
projecting back, but PostGIS does this as `ST_Buffer(<GEOGRAPHY>)` instead of
geometry + useSpheroid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
