Abeeujah commented on code in PR #241:
URL: https://github.com/apache/sedona-db/pull/241#discussion_r2462977143
##########
c/sedona-geos/src/st_buffer.rs:
##########
@@ -32,6 +32,19 @@ use sedona_schema::{
use crate::executor::GeosExecutor;
/// ST_Buffer() implementation using the geos crate
+///
+/// Supports three signatures:
+/// - ST_Buffer(geometry: Geometry, distance: Double)
+/// - ST_Buffer(geometry: Geometry, distance: Double, useSpheroid: Boolean)
+/// - ST_Buffer(geometry: Geometry, distance: Double, useSpheroid: Boolean,
bufferStyleParameters: String)
Review Comment:
I think, seeing the Sedona reference in the issue description made me think
it was the more favored one, but I just updated it to use the postgis
signature, please do check and let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
