Kontinuation commented on code in PR #598:
URL: https://github.com/apache/sedona-db/pull/598#discussion_r2794230894
##########
rust/sedona-spatial-join/src/prepare.rs:
##########
@@ -296,8 +297,14 @@ impl SpatialJoinComponentsBuilder {
Ok(build_partitioner)
}
- /// Construct a `SpatialPartitioner` (e.g. Flat) from the statistics of
partitioned build
- /// side for partitioning the probe side.
+ /// The number of partitions above which the probe side uses an RTree
+ /// partitioner instead of a flat (linear-scan) partitioner. Benchmarks
+ /// show the crossover at ~36 partitions; 48 gives a comfortable margin.
Review Comment:
The original comment is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
