Kontinuation commented on code in PR #598: URL: https://github.com/apache/sedona-db/pull/598#discussion_r2794238998
########## rust/sedona-spatial-join/bench/partitioning/flat_vs_rtree.rs: ########## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Head-to-head benchmark of FlatPartitioner vs RTreePartitioner across +//! varying partition counts to find the optimal switch point. + +mod common; + +use std::hint::black_box; + +use common::{default_extent, grid_partitions, sample_queries, QUERY_BATCH_SIZE}; +use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion, Throughput}; +use sedona_spatial_join::partitioning::{ + flat::FlatPartitioner, rtree::RTreePartitioner, SpatialPartitioner, +}; + +/// Grid dimensions to benchmark. Each produces dim*dim partitions. +/// 4x4=16, 5x5=25, 6x6=36, 8x8=64, 10x10=100, 16x16=256, 20x20=400 Review Comment: The original comment is good enough. The suggest comment looks like showing a time traveler's dilemma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
