paleolimbot commented on code in PR #598: URL: https://github.com/apache/sedona-db/pull/598#discussion_r2795101289
########## rust/sedona-spatial-join/bench/partitioning/common.rs: ########## @@ -16,6 +16,10 @@ // under the License. //! Shared helpers for partitioner benchmarks. +//! +//! This module is included (`mod common;`) by multiple independent bench binaries, +//! not all of which use every item. Suppress dead-code warnings accordingly. +#![allow(dead_code)] Review Comment: I would love to avoid a module-level clippy allow (so we can know that this needs to be removed if there's a time when all the benchmarks stop using it). Maybe you can make this a pub export of a regular module in `src` called `internal_benchmark_util`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
