[ 
https://issues.apache.org/jira/browse/SENTRY-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613765#comment-16613765
 ] 

Hadoop QA commented on SENTRY-2109:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12913741/SENTRY-2109-rebase-SENTRY-2106.014.patch
 against master.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
error: 
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java:
 does not exist in index
error: 
a/sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java:
 does not exist in index
error: 
a/sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java:
 does not exist in index
error: 
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java:
 does not exist in index
error: patch failed: 
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java:874
Falling back to three-way merge...
Applied patch to 
'sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java'
 with conflicts.
error: 
sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java:
 does not exist in index
error: 
sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java:
 does not exist in index
error: 
sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HiveNotificationFetcher.java:
 does not exist in index
error: 
sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java:
 does not exist in index
error: 
sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java:
 does not exist in index
error: 
sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java:
 does not exist in index
error: 
sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java:
 does not exist in index
error: 
sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHiveNotificationFetcher.java:
 does not exist in index
error: 
sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java:
 does not exist in index
The patch does not appear to apply with p0, p1, or p2



Console output: 
https://builds.apache.org/job/PreCommit-SENTRY-Build/4103/console

This message is automatically generated.

> Fix the logic of identifying HMS out of Sync and handle gaps and 
> out-of-sequence notifications.
> -----------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-2109
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2109
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>         Attachments: SENTRY-2109-rebase-SENTRY-2106.014.patch, 
> SENTRY-2109.001.patch, SENTRY-2109.002.patch, SENTRY-2109.003.patch, 
> SENTRY-2109.004.patch, SENTRY-2109.005.patch, SENTRY-2109.006.patch, 
> SENTRY-2109.007.patch, SENTRY-2109.008.patch, SENTRY-2109.009.patch, 
> SENTRY-2109.010.patch, SENTRY-2109.010.patch, SENTRY-2109.011.patch, 
> SENTRY-2109.012.patch, SENTRY-2109.012.patch, SENTRY-2109.012.patch, 
> SENTRY-2109.013.patch, Screenshot_HMS_NOTIFICATION_LOG.png
>
>
> Currently HMSFollower proactively checks if sentry is out of sync with HMS 
> and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the 
> event-id in the notification log sequence.
> This jira is aimed at making that logic robust.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to