Alexander Kolbasov commented on SENTRY-2109:

[~kkalyan] I would appreciate if you revert the patch and we complete the 
discussion review and then you commit (or not commit) whatever comes out of it.

This patch had many iterations. There were several reviewers who had comments 
about earlier versions of the patch and some reviewers posted unanswered 
comments in this Jira so it is pretty clear that the review wasn't complete 
even though you got one +1 from a committer. 

I think that the best course of action is to revert the patch and complete the 


> Fix the logic of identifying HMS out of Sync and handle gaps and 
> out-of-sequence notifications.
> -----------------------------------------------------------------------------------------------
>                 Key: SENTRY-2109
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2109
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>             Fix For: 2.1.0
>         Attachments: SENTRY-2109.001.patch, SENTRY-2109.002.patch, 
> SENTRY-2109.003.patch, SENTRY-2109.004.patch, SENTRY-2109.005.patch, 
> SENTRY-2109.006.patch, SENTRY-2109.007.patch, SENTRY-2109.008.patch, 
> SENTRY-2109.009.patch, SENTRY-2109.010.patch, SENTRY-2109.010.patch, 
> SENTRY-2109.011.patch, SENTRY-2109.012.patch, SENTRY-2109.012.patch, 
> SENTRY-2109.012.patch, Screenshot_HMS_NOTIFICATION_LOG.png
> Currently HMSFollower proactively checks if sentry is out of sync with HMS 
> and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the 
> event-id in the notification log sequence.
> This jira is aimed at making that logic robust.

This message was sent by Atlassian JIRA

Reply via email to