kalyan kumar kalvagadda commented on SENTRY-2109:


This is what the patch does functionally.
 # Make sure that additional snapshots are not taken because of GAPS in the 
 # Make sure that notification are not missed even when there are GAPS and 
out-of-sequence notifications.

we know that issue of gaps and out-of-sequence in the events will be solved 
with Hive fix done for HIVE-18526 . Only justification to have this patch was 
to safe guard sentry and be able to handle cases where events are not received 
in proper order. It's reasonable not assuming that other components would 
behave correctly and have some functionality in place to handle the error 
I will revert the patch if you say so.

> Fix the logic of identifying HMS out of Sync and handle gaps and 
> out-of-sequence notifications.
> -----------------------------------------------------------------------------------------------
>                 Key: SENTRY-2109
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2109
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>            Priority: Major
>             Fix For: 2.1.0
>         Attachments: SENTRY-2109.001.patch, SENTRY-2109.002.patch, 
> SENTRY-2109.003.patch, SENTRY-2109.004.patch, SENTRY-2109.005.patch, 
> SENTRY-2109.006.patch, SENTRY-2109.007.patch, SENTRY-2109.008.patch, 
> SENTRY-2109.009.patch, SENTRY-2109.010.patch, SENTRY-2109.010.patch, 
> SENTRY-2109.011.patch, SENTRY-2109.012.patch, SENTRY-2109.012.patch, 
> SENTRY-2109.012.patch, Screenshot_HMS_NOTIFICATION_LOG.png
> Currently HMSFollower proactively checks if sentry is out of sync with HMS 
> and initiates full snapshot, if needed.
> There will be false positives with the current logic if there are gaps in the 
> event-id in the notification log sequence.
> This jira is aimed at making that logic robust.

This message was sent by Atlassian JIRA

Reply via email to