[ https://issues.apache.org/jira/browse/SCB-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360271#comment-16360271 ]
ASF GitHub Bot commented on SCB-327: ------------------------------------ zhengyangyong opened a new pull request #555: [SCB-327] Update metrics publish data module URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- Re-organize comment of PR : https://github.com/apache/incubator-servicecomb-java-chassis/pull/550 adjust metrics publish format to spring cloud netflix style Before: servicecomb.instance.system.cpu.load servicecomb.instance.system.cpu.runningThreads servicecomb.instance.system.heap.init servicecomb.instance.system.heap.max servicecomb.instance.system.heap.commit servicecomb.instance.system.heap.used servicecomb.instance.system.nonHeap.init servicecomb.instance.system.nonHeap.max servicecomb.instance.system.nonHeap.commit servicecomb.instance.system.nonHeap.used servicecomb.instance | operationName.producer.waitInQueue.count servicecomb.instance | operationName.producer.lifeTimeInQueue.average servicecomb.instance | operationName.producer.lifeTimeInQueue.max servicecomb.instance | operationName.producer.lifeTimeInQueue.min servicecomb.instance | operationName.producer.executionTime.average servicecomb.instance | operationName.producer.executionTime.max servicecomb.instance | operationName.producer.executionTime.min servicecomb.instance | operationName.producer.producerLatency.average servicecomb.instance | operationName.producer.producerLatency.max servicecomb.instance | operationName.producer.producerLatency.min servicecomb.instance | operationName.producer.producerCall.total servicecomb.instance | operationName.producer.producerCall.tps servicecomb.instance | operationName.consumer.consumerLatency.average servicecomb.instance | operationName.consumer.consumerLatency.max servicecomb.instance | operationName.consumer.consumerLatency.min servicecomb.instance | operationName.consumer.consumerCall.total servicecomb.instance | operationName.consumer.consumerCall.tps Current: jvm(statistic=gauge,name={name}) {name} include : **cpuLoad,cpuRunningThreads,heapInit,heapMax,heapCommit, heapUsed,nonHeapInit,nonHeapMax,nonHeapCommit,nonHeapUsed** servicecomb.invocation(operation={operationName},role={role},stage={stage},statistic={statistic},status={status}) | TagName | TagValue | | :---------- | :--------------------- | | operation | Operation Name | | role | consume,producer | | stage | queue,execution,whole | | statistic | tps,totalCount,count,totalTime,max,waitInQueue (can compute latency = totalTime/count) | | status | statusCode like 200, 404 ... etc| A output sample: ![tim 20180206161636](https://user-images.githubusercontent.com/374335/35859674-fa02673a-0b7b-11e8-9219-4bf0ab3a1c8a.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update metrics publish data module > ---------------------------------- > > Key: SCB-327 > URL: https://issues.apache.org/jira/browse/SCB-327 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis > Affects Versions: java-chassis-1.0.0-m1 > Reporter: yangyongzheng > Assignee: yangyongzheng > Priority: Major > Fix For: java-chassis-1.0.0-m1 > > > Change data publish from RegistryMetric model to map > adjust metrics publish format to spring cloud netflix style -- This message was sent by Atlassian JIRA (v7.6.3#76005)